Fix build server only deploys arm64 macOS binaries #1835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By introducing another runner, so we can deploy arm64 and intel separately
15f5936 to
88d4627
Compare
J5lx
reviewed
Apr 26, 2024
Co-authored-by: Jakob <j5lx@fmail.co.uk>
chchwy
reviewed
Apr 29, 2024
chchwy
approved these changes
Apr 30, 2024
|
Hey @J5lx, is this PR ok to merge? |
|
I have no objections, but I’m not a macOS user. |
Thanks! |
chchwy
pushed a commit
that referenced
this pull request
May 22, 2024
* Fix build server only deploys arm64 macOS binaries By introducing another runner, we can deploy arm64 and intel separately * Update .github/actions/create-package/create-package.sh Co-authored-by: Jakob <j5lx@fmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this for now by introducing more mac os runners. This means that we deploy proper arm64 builds now as well as x86_64.
Ideally we would build universal binaries but Homebrew does not support building cross platform, as such we would have to build Qt ourselves in order to support this.
Note: We have to remember to make changes to the website, so we can see both new build types