Fix truncated playback for converted audio clips on Windows #1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at the truncated audio issue for certain file formats and figured out how to fix it – or work around it, rather. Once again, it’s an issue that is specific to the DirectShow multimedia backend on Windows. This backend seems to have trouble properly playing WAV files containing certain metadata that FFmpeg includes. I actually looked at the files in a hex editor and the format of the metadata looks completely fine, so FFmpeg doesn’t do anything wrong here AFAICT. I also tried both the GStreamer backend and the Windows Media Foundation backend and both of those worked fine. It’s really just the DirectShow backend that doesn’t work properly. As a workaround I simply added some FFmpeg options to strip all metadata. Because users could conceivably import problematic WAV files directly, I also made it so that WAV files too are processed through FFmpeg to strip any and all metadata.