Add AppImageUpdate support to Linux AppImage releases #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bundle zsync data for release builds.
|
Pretty cool! I’ll take a look at this later today |
J5lx
requested changes
Nov 21, 2021
There was a problem hiding this comment.
Looks good overall. I noticed one small issue in the zsync metadata which still contained the original filename (from before the rename), but I fixed that over here: scribblemaniac#8 I also adjusted the upload action to upload both files individually instead of zipped. Once that is merged (the zsync fix to be precise) this PR should be good to go as far as I’m concerned. Well done!
P.S. Here are the links to the AppImage and the zsync file.
Improve AppImage update support
|
The appimage seems to have the correct data as far as I can tell. Thanks for testing and the fixes. |
J5lx
approved these changes
Jan 11, 2022
J5lx
added a commit
that referenced
this pull request
Jan 11, 2022
[WIP] Add AppImageUpdate support to Linux AppImage releases
|
GitHub apparently didn’t recognize the merge again, so I’m closing this manually. The PR has been merged, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the update information to the appimage through linuxdeploy's
updateinformationparameter when building from the release branch. This should cause it to generate a .zsync file which is zipped together with the AppImage for release uploads. In future releases this file will be included with the other release assets on Github.This is marked WIP because I do not have the ability to full test this (my fork's CI environment is not set up to support uploads). I need someone to test that it uploads the files correctly still for the Linux builds, particularly on a release branch. I have tested enough to tell that it will work up until the upload step at least on both release and non-release branches. If someone could share the uploaded or link the release zip here, that would also be helpful as someone needs to verify that the update information is correctly embedded in the appimage and I should be able to do that if I get a copy of the appimage.