Skip to content

Conversation

acidicX
Copy link
Contributor

@acidicX acidicX commented Nov 27, 2018

should fix dominictarr/event-stream#116

Note: to upgrade to got 9 we would need to drop node 6 and 7 support.
But this package could be used on node 6 & 7, it just won't build on the platform.

@acidicX acidicX requested a review from jhnns November 27, 2018 11:45
@acidicX acidicX self-assigned this Nov 27, 2018
@jhnns jhnns merged commit 73a8b82 into master Nov 27, 2018
@jhnns jhnns deleted the update-deps-fix-vuln branch November 27, 2018 12:05
@jhnns
Copy link
Member

jhnns commented Nov 27, 2018

👍

got is not critical now, so it's good to keep the old version, so we can push a non-breaking change.

@jhnns
Copy link
Member

jhnns commented Nov 27, 2018

Published as 2.1.7 🚀

Copy link

@IzmaDoezIt IzmaDoezIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@PannawatC
Copy link

Go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I don't know what to say.
4 participants