Base58.h change to allow importing of private keys from Vanitygen #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Base58 version to allow importing of private keys. Note: Any private keys dumped from a PPCoin daemon version prior to the commit will be in an incompatible Base58 version. After installing the new version of PPCoin, simply dump the addresses again to get private keys of the correct version. This only affects private keys dumped directly from the PPCoin daemon. Vanitygen addresses are not affected as they are the correct version, provided they are generated with the -X 55 switch.
sunnyking
added a commit
that referenced
this pull request
Feb 12, 2013
Base58.h change to allow importing of private keys from Vanitygen
Closed
glv2
pushed a commit
to glv2/peercoin
that referenced
this pull request
Apr 13, 2014
Code formatting fix to address OS X `ppcoind` build (10.9 / Mavericks) issue
mhirki
pushed a commit
that referenced
this pull request
Jun 6, 2014
…BitcoinMiner(). This fixes an assertion failure crash when starting ppcoin-qt. The assertion failure is caused by a static call to the _() function. The issue is fixed by making strMintMessage a non-static local variable inside BitcoinMiner(). Assertion failure message (from Sunny): ppcoin-qt: /usr/include/boost/smart_ptr/shared_ptr.hpp:412: boost::shared_ptr<T>::reference boost::shared_ptr<T>::operator*() const [ with T = <snip> ]: Assertion `px != 0' failed. Backtrace of the crash: #0 0x0000003565435309 in raise () from /lib64/libc.so.6 #1 0x0000003565436668 in abort () from /lib64/libc.so.6 #2 0x000000356542e476 in __assert_fail_base () from /lib64/libc.so.6 #3 0x000000356542e522 in __assert_fail () from /lib64/libc.so.6 #4 0x0000000000475dbe in operator* (this=<optimized out>) at /usr/include/boost/smart_ptr/shared_ptr.hpp:646 #5 operator() (arg1=0x649fd8 "Info: Minting suspended due to locked wallet.", this=<optimized out>) at /usr/include/boost/signals2/detail/signal_template.hpp:695 #6 _ (psz=psz@entry=0x649fd8 "Info: Minting suspended due to locked wallet.") at src/ui_interface.h:106 #7 0x000000000049f5f7 in __static_initialization_and_destruction_0 (__initialize_p=__initialize_p@entry=1, __priority=__priority@entry=65535) at src/main.cpp:3345 #8 0x00000000004af11a in _GLOBAL__sub_I_cs_setpwalletRegistered () at src/main.cpp:5303 #9 0x0000000000620d0d in __libc_csu_init () #10 0x0000003565421aa5 in __libc_start_main () from /lib64/libc.so.6 #11 0x000000000042b9f8 in _start ()
Beirdo
pushed a commit
to BeirdoMud/MudCoin
that referenced
this pull request
Oct 14, 2017
fix stake 2
backpacker69
pushed a commit
that referenced
this pull request
Mar 7, 2019
07947ff2da Merge #9: [tests] Fix BOOST_CHECK_THROW macro ec849d9a28 [tests] Fix BOOST_CHECK_THROW macro 31bc9f5a49 Merge #8: Remove unused Homebrew workaround fa042093d1 Remove HomeBrew workaround a523e08ae4 Merge #7: Declare single-argument (non-converting) constructors "explicit" a9e53b38ba Merge #4: Pull upstream 16a1f7f6e9 Merge #3: Pull upstream daf1285af6 Merge pull request #2 from jgarzik/master f32df99e96 Merge branch '2016_04_unicode' into bitcoin 280b191cb1 Merge remote-tracking branch 'jgarzik/master' into bitcoin 2740c4f712 Merge branch '2015_11_escape_plan' into bitcoin git-subtree-dir: src/univalue git-subtree-split: 07947ff2da9ef02a9dfa13346bc5545708e3ebe7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Base58 version to allow importing of private keys from Vanitygen.
Note: Any private keys dumped from a PPCoin daemon version prior to the commit will be in an incompatible Base58 version. After installing the new version of PPCoin, simply dump the addresses again to get private keys of the correct version.
This only affects private keys dumped directly from the PPCoin daemon. Vanitygen addresses are not affected as they are the correct version, provided they are generated with the -X 55 switch.
Thanks to Sunny for further refinement of my original pull request submitted under dreamwatcher. I have changed my git account to Hartland to reflect my business name.