Skip to content

Belovachap/compiler warnings #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2020
Merged

Belovachap/compiler warnings #520

merged 4 commits into from
Mar 23, 2020

Conversation

belovachap
Copy link
Contributor

Address some of the compiler warnings that might have come from us.

@backpacker69
Copy link
Member

we are likely to have softforks in future why do you remove this code?

@belovachap
Copy link
Contributor Author

we are likely to have softforks in future why do you remove this code?

The compiler warning that prompted me to remove it:

rpc/blockchain.cpp:1053:17: warning: ‘UniValue SoftForkDesc(const string&, int, CBlockIndex*, const Consensus::Params&)’ defined but not used [-Wunused-function]
 static UniValue SoftForkDesc(const std::string &name, int version, CBlockIndex* pindex, const Consensus::Params& consensusParams)
                 ^~~~~~~~~~~~

but if you think we'll need SoftForkDesc at some point, I've added it back in :)

@backpacker69 backpacker69 merged commit 1727028 into peercoin:release-0.9 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backpacker69 backpacker69 backpacker69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belovachap @backpacker69