Skip to content

command: add --exclude flag #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Aug 6, 2021
Merged

command: add --exclude flag #334

merged 38 commits into from
Aug 6, 2021

Conversation

ocakhasan
Copy link
Contributor

@ocakhasan ocakhasan commented Aug 2, 2021 •
edited
Loading

  • --exclude flag is implemented in rm, ls, cp, du and select.
  • --exclude flag is used to exclude objects which fits to given pattern.
  • all command tests are included apart from select.

Resolves #266

ocakhasan added 24 commits July 13, 2021 15:27
@ocakhasan
added exclude first commit, not stable
6238f74
@ocakhasan
added --exclude flag to other methods and complete tests
749bed6
@ocakhasan
add tests
9e3814e
@ocakhasan
change empty strings to excludePattern variable for better understanding
648e9c9
@ocakhasan
Merge branch 'master' into exclude
4f42708
@ocakhasan
changed expandSource to previous version, exclude objects in for loop
9096c8c
@ocakhasan
merge from peak/master and fix conflicts
bb0e9be
@ocakhasan
Merge branch 'master' into exclude
95912ba
@ocakhasan
make exclude usable more than one and include test cases for multiple…
4f54b55 
… exclude patterns
@ocakhasan
added usage cases for exclude flag
19570c3
@ocakhasan
changes according to pr updates
f729203
@ocakhasan
change usage to correct form
2014766
@ocakhasan
delete unnecessary empty lines
0ca91c2
@ocakhasan
merge from master and solve conflicts
4ca25bf
@ocakhasan
update changelog.md
be68bda
@ocakhasan
add empty lines below headers
99f5126
@ocakhasan
create exclude url so we do not need to calculate regex in each sourc…
67fe5ba 
…e url
@ocakhasan
Merge branch 'master' into exclude
66192d1
@ocakhasan
back to old version
dc18df5
@ocakhasan
Merge branch 'master' into oldexclude
8b28a2b
@ocakhasan
delete test folder deneme
6d0b080
@ocakhasan
changes according to review
16679ab
@ocakhasan
added remove tests
5bcd270
@ocakhasan
remove test folder deneme
9040147
@ocakhasan ocakhasan mentioned this pull request Aug 3, 2021
Closed
@ocakhasan ocakhasan marked this pull request as ready for review August 3, 2021 09:36
@ocakhasan ocakhasan requested a review from a team as a code owner August 3, 2021 09:36
@ocakhasan ocakhasan requested review from ilkinulas and seruman and removed request for a team August 3, 2021 09:36
seruman
seruman requested changes Aug 3, 2021
View reviewed changes
seruman
seruman requested changes Aug 3, 2021
View reviewed changes
seruman
seruman requested changes Aug 4, 2021
View reviewed changes
seruman
seruman reviewed Aug 4, 2021
View reviewed changes
seruman
seruman reviewed Aug 4, 2021
View reviewed changes
seruman
seruman reviewed Aug 4, 2021
View reviewed changes
seruman
seruman reviewed Aug 4, 2021
View reviewed changes
seruman
seruman reviewed Aug 4, 2021
View reviewed changes
@ocakhasan ocakhasan changed the title command: add --exclude flag without URL command: add --exclude flag Aug 5, 2021
@seruman seruman merged commit 604f03a into peak:master Aug 6, 2021
@ocakhasan ocakhasan deleted the exclude_new branch August 11, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seruman seruman seruman approved these changes

@ilkinulas ilkinulas Awaiting requested review from ilkinulas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request for --include and --exclude filters
2 participants
@ocakhasan @seruman