command/cp&rm: add `--raw` flag #315

ocakhasan · 2021-07-08T10:59:55Z

command/cp&rm: new flag --raw which disables the wildcard operations.
also changed the rb command's helper text to correct form, based on this commit.

resolves #235

command/cp.go

command/expand.go

command/expand_test.go

command/expand.go

…ng raw operations

command/expand.go

command/rm.go

storage/url/url.go

command/expand_test.go

command/rm.go

command/expand.go

command/cp.go

storage/url/url.go

command/cp.go

storage/url/url.go

storage/url/url_test.go

e2e/cp_test.go

Co-authored-by: İlkin Balkanay <ilkinulas@gmail.com>

e2e/cp_test.go

command/cp.go

ocakhasan added 8 commits July 8, 2021 11:01

getting error while creating file e.g hasan*.txt

9692d9d

update isbatch with raw flag, it seems to work

019bfe7

added --raw flag to rm command

bcb6e39

added new test regarding raw flag to expand_test.go

d35e738

skip expand_test new cases in windows

84005cf

added new tests for --raw flag

fa769b1

added tests for --raw flag to cp and rm operation

8759a20

Merge branch 'master' into newRaw

4e6c8ec

ocakhasan changed the title ~~added --raw flag to cp and rm flag.~~ command/cp&rm: add --raw flag Jul 9, 2021

ocakhasan changed the title ~~command/cp&rm: add --raw flag~~ command/cp&rm: add --raw flag Jul 9, 2021

ocakhasan added 3 commits July 9, 2021 16:00

deleted the error line

d6a88c2

skip test if OS in windows

74faa48

merge with master and solve conflicts

1472d68

aykutfarsak reviewed Jul 9, 2021

View reviewed changes

command/cp.go Outdated Show resolved Hide resolved

command/expand.go Outdated Show resolved Hide resolved

command/expand_test.go Outdated Show resolved Hide resolved

command/expand_test.go Outdated Show resolved Hide resolved

ocakhasan added 3 commits July 10, 2021 22:11

Merge branch 'master' into newRaw

78de7da

add bool isRaw to command/select.go

5e7d249

changed expand_test function names to more detailed and fix some comment

240d0f8

ilkinulas self-requested a review July 12, 2021 14:00

ocakhasan marked this pull request as ready for review July 12, 2021 14:01

ocakhasan requested a review from a team as a code owner July 12, 2021 14:01

ocakhasan requested review from sonmezonur and removed request for a team July 12, 2021 14:01

Merge branch 'master' into newRaw

63bed58

ilkinulas reviewed Jul 14, 2021

View reviewed changes

command/expand.go Outdated Show resolved Hide resolved

delete parameter from expandSource and create new function for handli…

1d045e4

…ng raw operations

ilkinulas reviewed Jul 14, 2021

View reviewed changes

command/expand.go Outdated Show resolved Hide resolved

ocakhasan added 2 commits July 25, 2021 12:38

changed rawSource function and merge from peak/master

f629dde

merge from peak/master and fix conflicts

dc822e4

ilkinulas reviewed Jul 26, 2021

View reviewed changes

command/expand.go Outdated Show resolved Hide resolved

ilkinulas reviewed Jul 26, 2021

View reviewed changes

command/rm.go Outdated Show resolved Hide resolved

ocakhasan added 4 commits July 26, 2021 16:16

changed folder name

72b2d13

added tests for url.go

9d8bd81

deleted unnecessary fmt line

7603e20

deleted deneme.txt

fa74b4b

ilkinulas reviewed Jul 27, 2021

View reviewed changes

storage/url/url.go Outdated Show resolved Hide resolved

changed urlmode from integer to bool

e0db462

ilkinulas reviewed Jul 27, 2021

View reviewed changes

command/expand_test.go Outdated Show resolved Hide resolved

ocakhasan added 2 commits July 27, 2021 11:08

removed unnecessary rawSource method and delete the related tests

d622705

change url mode to bool and fix some tests

ae2bcea

sonmezonur reviewed Jul 27, 2021

View reviewed changes

storage/url/url.go Outdated Show resolved Hide resolved

changes according to pr updates

096e593

ilkinulas reviewed Jul 27, 2021

View reviewed changes

storage/url/url_test.go Outdated Show resolved Hide resolved

changes according to pr updates

00dee88

ilkinulas reviewed Jul 27, 2021

View reviewed changes

e2e/cp_test.go Outdated Show resolved Hide resolved

Update e2e/cp_test.go

e8a0c6c

Co-authored-by: İlkin Balkanay <ilkinulas@gmail.com>

ilkinulas reviewed Jul 27, 2021

View reviewed changes

e2e/cp_test.go Outdated Show resolved Hide resolved

ocakhasan added 2 commits July 27, 2021 18:33

refactor tests

194c418

changed tests and rename hasGlob to isWildcard()

748b85c

ilkinulas reviewed Jul 27, 2021

View reviewed changes

e2e/cp_test.go Outdated Show resolved Hide resolved

ilkinulas reviewed Jul 27, 2021

View reviewed changes

e2e/cp_test.go Outdated Show resolved Hide resolved

changes in cp_test according to pr review

d722b23

ilkinulas approved these changes Jul 28, 2021

View reviewed changes

delete empty line

910466a

sonmezonur reviewed Jul 28, 2021

View reviewed changes

command/cp.go Outdated Show resolved Hide resolved

deleted unncessary comment line

ee92410

sonmezonur approved these changes Jul 28, 2021

View reviewed changes

ilkinulas merged commit 5a611da into peak:master Jul 28, 2021

ocakhasan deleted the newRaw branch August 2, 2021 15:54

PApostol mentioned this pull request Dec 8, 2022

Support --raw flag with cat #539

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

command/cp&rm: add `--raw` flag #315

command/cp&rm: add `--raw` flag #315

Uh oh!

ocakhasan commented Jul 8, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

command/cp&rm: add --raw flag #315

command/cp&rm: add --raw flag #315

Uh oh!

Conversation

ocakhasan commented Jul 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

command/cp&rm: add `--raw` flag #315

command/cp&rm: add `--raw` flag #315

ocakhasan commented Jul 8, 2021 •

edited

Loading