-
Notifications
You must be signed in to change notification settings - Fork 288
command/cp: Allow overriding bucket region #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add two parameters to `cp` and set region in session
Applying suggestion from aykutfarsak Co-authored-by: Aykut Farsak <aykutfarsak@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and sorry for the late feedback. LGTM aside from some minor comments
src-region is renamed to source-region; dst-region is renamed to destination-region
Co-authored-by: H. İbrahim Güngör <igungor@gmail.com>
Co-authored-by: H. İbrahim Güngör <igungor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the SetRegion function to use pointers, along with the typo in the description for destination-region
Thank you. |
Add two parameters to
cp
and set region in sessionThis can be one way to resolve #262