Skip to content

Conversation

kemege
Copy link
Contributor

@kemege kemege commented Jan 20, 2021

Add two parameters to cp and set region in session
This can be one way to resolve #262

Add two parameters to `cp` and set region in session
@kemege kemege requested a review from a team as a code owner January 20, 2021 07:03
@kemege kemege requested review from aykutfarsak and sonmezonur and removed request for a team January 20, 2021 07:03
aykutfarsak and others added 2 commits June 22, 2021 18:02
Applying suggestion from aykutfarsak

Co-authored-by: Aykut Farsak <aykutfarsak@gmail.com>
Copy link
Member

@sonmezonur sonmezonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and sorry for the late feedback. LGTM aside from some minor comments

kemege and others added 2 commits July 1, 2021 19:26
src-region is renamed to source-region; dst-region is renamed to destination-region
Copy link
Contributor Author

@kemege kemege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the SetRegion function to use pointers, along with the typo in the description for destination-region

@igungor
Copy link
Member

igungor commented Jul 5, 2021

I've changed the SetRegion function to use pointers, along with the typo in the description for destination-region

Thank you.

@igungor igungor merged commit b4c91bd into peak:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region setting not working
5 participants