command: fix file overriding when download fails (#479) #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonmezonur
previously approved these changes
Jul 6, 2023
|
@ahmethakanbesel Thanks for your PR. Could you please link your PR to the issue? (when PR merged it will automatically close the referenced issue) (docs) |
sonmezonur
reviewed
Jul 6, 2023
sonmezonur
reviewed
Jul 7, 2023
sonmezonur
reviewed
Jul 7, 2023
sonmezonur
reviewed
Jul 7, 2023
sonmezonur
previously approved these changes
Jul 7, 2023
ilkinulas
reviewed
Jul 12, 2023
Co-authored-by: İlkin Balkanay <ilkinulas@gmail.com>
ilkinulas
approved these changes
Jul 12, 2023
sonmezonur
approved these changes
Jul 13, 2023
This was referenced Jul 20, 2023
This was referenced Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #479
Local files used to be overwritten even if downloads failed.
Solved it by creating a temporary file and renaming it with the original filename after completing the download successfully.