Skip to content

command/sync: fix delete option with empty target #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 6, 2023
Merged

command/sync: fix delete option with empty target #578

merged 5 commits into from
Jul 6, 2023

Conversation

seruman
Copy link
Contributor

@seruman seruman commented Jun 22, 2023 •
edited
Loading

Fixes #576,
Thanks to @kucukaslan for pointing it out.

kucukaslan
kucukaslan reviewed Jun 22, 2023
View reviewed changes
@seruman seruman force-pushed the sync-empty-target-with-delete branch from a52f13d to d98beff Compare June 22, 2023 16:52
@seruman seruman marked this pull request as ready for review June 23, 2023 11:42
@seruman seruman requested a review from a team as a code owner June 23, 2023 11:42
@seruman seruman requested review from ilkinulas and sonmezonur and removed request for a team June 23, 2023 11:42
igungor
igungor reviewed Jun 23, 2023
View reviewed changes
@seruman seruman merged commit bb3723b into master Jul 6, 2023
@seruman seruman deleted the sync-empty-target-with-delete branch July 6, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igungor igungor igungor left review comments

@ilkinulas ilkinulas ilkinulas approved these changes

@sonmezonur sonmezonur sonmezonur approved these changes

+1 more reviewer

@kucukaslan kucukaslan kucukaslan left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in sync command when using --delete flag with 2.1.0 release
5 participants
@seruman @igungor @ilkinulas @sonmezonur @kucukaslan