Skip to content

e2e/util_test: remove unnecessary test directory cleanup #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2022
Merged

e2e/util_test: remove unnecessary test directory cleanup #512

merged 1 commit into from
Sep 14, 2022

Conversation

igungor
Copy link
Member

@igungor igungor commented Sep 13, 2022

fs.NewDir already deletes the directory on test exits.

@igungor
e2e/util_test: remove unnecessary test directory cleanup
333f9c8 
`fs.NewDir` already deletes the directory on test exits.
@igungor igungor requested a review from a team as a code owner September 13, 2022 17:38
@igungor igungor requested review from ilkinulas and seruman and removed request for a team September 13, 2022 17:38
@igungor igungor merged commit 37e9a68 into master Sep 14, 2022
@igungor igungor deleted the remove-unnecessary-cleanup branch September 14, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seruman seruman seruman approved these changes

@sonmezonur sonmezonur sonmezonur approved these changes

@ilkinulas ilkinulas Awaiting requested review from ilkinulas ilkinulas is a code owner automatically assigned from peak/big-data

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igungor @seruman @sonmezonur