flag/stat: fix omitted stat in error log level #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create unit & e2e tests Fixes peak#359 Co-Authored-By: Muhammed Can Küçükaslan <32893303+muhammedcankucukaslan@users.noreply.github.com>
Co-Authored-By: Muhammed Can Küçükaslan <32893303+muhammedcankucukaslan@users.noreply.github.com>
Co-Authored-By: Muhammed Can Küçükaslan <32893303+MuhammedCanKucukaslan@users.noreply.github.com>
igungor
reviewed
Jun 30, 2022
Removed unit tests in log_test.go as they are already tested in TestAppDashStat under e2e/app_test.go Removed redundant integration test which is already covered by another test in the same file. Co-Authored-By: Muhammed Can Küçükaslan <32893303+MuhammedCanKucukaslan@users.noreply.github.com>
seruman
approved these changes
Jun 30, 2022
ilkinulas
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create unit & e2e tests
Fixes #359
Co-Authored-By: Muhammed Can Küçükaslan 32893303+muhammedcankucukaslan@users.noreply.github.com