Skip to content

command/run: drop inline comment support #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Conversation

igungor
Copy link
Member

@igungor igungor commented Apr 6, 2022

Previously s5cmd supported a command with an inline comment like ls s3://bucket/object.gz # inline comment.

Comment per line is still supported.

Fixes #309

Previously s5cmd supported a command with an inline comment like `ls s3://bucket/object.gz  # inline comment` was supported.

Comment per line is still supported.

Fixes #309
@igungor igungor requested a review from a team as a code owner April 6, 2022 08:16
@igungor igungor requested review from aykutfarsak and sonmezonur and removed request for a team April 6, 2022 08:16
@igungor igungor added this to the v2.0.0 milestone Apr 6, 2022
@igungor igungor merged commit ef19ae8 into master Apr 6, 2022
@igungor igungor deleted the drop-inline-comment branch April 6, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to process files with a hash sign in commands file
3 participants