Skip to content

Add black code style #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2022
Merged

Add black code style #114

merged 2 commits into from
Dec 24, 2022

Conversation

DavidKatz-il
Copy link
Contributor

@DavidKatz-il DavidKatz-il temporarily deployed to checkdocs December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:26 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:27 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:27 — with GitHub Actions Inactive
@DavidKatz-il DavidKatz-il temporarily deployed to test December 13, 2022 11:27 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

Merging #114 (f891e6c) into master (07db68a) will not change coverage.
The diff coverage is 98.22%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #114    +/-   ##
========================================
  Coverage   98.06%   98.06%            
========================================
  Files          25       25            
  Lines        3676     3676            
  Branches      652      474   -178     
========================================
  Hits         3605     3605            
  Misses         56       56            
  Partials       15       15
Impacted Files Coverage Δ
pdpipe/df/func_lists.py 100.00% <ø> (ø)
pdpipe/wrappers.py 100.00% <ø> (ø)
pdpipe/lbl.py 96.07% <33.33%> (ø)
pdpipe/core.py 90.67% <95.52%> (ø)
pdpipe/basic_stages.py 99.71% <100.00%> (ø)
pdpipe/cfg.py 100.00% <100.00%> (ø)
pdpipe/col_generation.py 100.00% <100.00%> (ø)
pdpipe/cond.py 100.00% <100.00%> (ø)
pdpipe/cq.py 100.00% <100.00%> (ø)
pdpipe/df/bound_column_potential.py 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07db68a...f891e6c. Read the comment docs.

shaypal5
shaypal5 approved these changes Dec 24, 2022
View reviewed changes
Copy link
Collaborator

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Awesome contribution. Thanks!

@shaypal5 shaypal5 merged commit 55bd17c into pdpipe:master Dec 24, 2022
@DavidKatz-il DavidKatz-il deleted the add_black_code_style branch December 24, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaypal5 shaypal5 shaypal5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: add more linters to get more uniform codebase
2 participants
@DavidKatz-il @shaypal5