fix: export from pylock.toml produces empty requirements.txt (#3573) #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where running `pdm export --lockfile pylock.toml` would produce empty requirements.txt files. The problem was that groups information from pylock markers was not being properly extracted and assigned to requirements, causing the export logic to skip all packages. Changes: - Added group extraction from pylock markers in _read_pylock() - Modified export command to use evaluate_candidates() for proper filtering - Added _extract_groups_from_marker() method to handle complex marker patterns - Added comprehensive tests for pylock export functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3575 +/- ##
==========================================
+ Coverage 85.17% 85.23% +0.06%
==========================================
Files 118 118
Lines 12017 12012 -5
Branches 1961 1959 -2
==========================================
+ Hits 10235 10238 +3
+ Misses 1217 1209 -8
Partials 565 565
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3573 - This resolves an issue where running
pdm export --lockfile pylock.tomlwould produce emptyrequirements.txt files.
Problem
The issue was that group information from pylock markers was not being properly extracted and assigned to requirements,
causing the export logic to skip all packages due to group filtering mismatches.
Co-Authored-By: Claude noreply@anthropic.com