Skip to content

fix: Search package metadata in lock file first when reuse #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

fix: Search package metadata in lock file first when reuse #3540

merged 1 commit into from
Jun 13, 2025

Conversation

frostming
Copy link
Collaborator

Fixes #3522

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov Codecov
Copy link

codecov bot commented Jun 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.39130% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (a93208d) to head (1722f99).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/models/repositories/lock.py 33.33% 6 Missing and 2 partials ⚠️
src/pdm/project/core.py 25.00% 2 Missing and 1 partial ⚠️
src/pdm/formats/uv.py 0.00% 1 Missing and 1 partial ⚠️
src/pdm/formats/pylock.py 50.00% 0 Missing and 1 partial ⚠️
src/pdm/resolver/providers.py 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3540      +/-   ##
==========================================
- Coverage   85.52%   85.26%   -0.27%     
==========================================
  Files         118      118              
  Lines       11941    11961      +20     
  Branches     1948     1952       +4     
==========================================
- Hits        10213    10199      -14     
- Misses       1173     1204      +31     
- Partials      555      558       +3
Flag Coverage Δ
unittests 85.13% <67.39%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frostming frostming force-pushed the frostming/issue3522 branch from cd8a373 to d168f9e Compare June 13, 2025 02:46
@frostming
fix: Search package metadata in lock file first when reuse
1722f99 
Fixes #3522

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming force-pushed the frostming/issue3522 branch from d168f9e to 1722f99 Compare June 13, 2025 02:52
@frostming frostming merged commit ae0b9b7 into main Jun 13, 2025
22 of 24 checks passed
@frostming frostming deleted the frostming/issue3522 branch June 13, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to search in lock file first when reuse
1 participant
@frostming