feat: move 'msgpack' to optional dependencies #3526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
reviewed
May 29, 2025
| return base64.b64decode(val) | ||
| return obj | ||
|
|
||
| class msgpack: # type:ignore[no-redef] |
There was a problem hiding this comment.
This class is clever, does this ensure both forward and backward compatibility? json loads msgpack content and msgpack loads json content
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3526 +/- ##
==========================================
- Coverage 85.20% 85.09% -0.12%
==========================================
Files 115 115
Lines 11768 11800 +32
Branches 2591 1935 -656
==========================================
+ Hits 10027 10041 +14
- Misses 1190 1205 +15
- Partials 551 554 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frostming
reviewed
May 30, 2025
frostming
reviewed
May 30, 2025
frostming
reviewed
May 30, 2025
…with data dumped by msgpack
frostming
approved these changes
Jun 4, 2025
frostming
pushed a commit
that referenced
this pull request
Jun 10, 2025
* feat: move msgpack to option deps * Add fragment to news/ * refactor: use classmethod * refactor: mock json as msgpack * chore: upgrade deps * ci: add tests without msgpack * refactor: forward and backward compatibility * tests: check compatibility for json and msgpack * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * refactor: return none instead of raises exception when loads by json with data dumped by msgpack --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
Fixes #3485
It is better to make 'msgpack' as optional dependency.