Skip to content

Conversation

monchin
Copy link
Contributor

@monchin monchin commented May 28, 2025

… from liststr

Pull Request Checklist

  • [√] A news fragment is added in news/ describing what is new.
  • [√] Test cases added for changed code.

Describe what you have changed in this PR.

fix #3523

Copy link

codecov bot commented May 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.20%. Comparing base (c0fb96d) to head (ee5e86e).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3524   +/-   ##
=======================================
  Coverage   85.20%   85.20%           
=======================================
  Files         115      115           
  Lines       11768    11768           
  Branches     2591     2591           
=======================================
  Hits        10027    10027           
  Misses       1190     1190           
  Partials      551      551           
Flag Coverage Δ
unittests 85.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@monchin
Copy link
Contributor Author

monchin commented May 28, 2025

pre-commit shows that

class PoetryMetaConverter(MetaConverter):
    @convert_from("authors")
    def authors(self, value: list[str]) -> list[str]:
        return parse_name_email(value)

    @convert_from("maintainers")
    def maintainers(self, value: list[str]) -> list[str]:
        return parse_name_email(value)

failed by mypy lint.

According to pep 621, both authors and maintainers should be list[dict], so I'll change it.

@frostming frostming merged commit 2e025ca into pdm-project:main May 29, 2025
23 of 24 checks passed
@monchin monchin deleted the fix/#3523 branch June 2, 2025 17:37
frostming pushed a commit that referenced this pull request Jun 10, 2025
#3524)

* fix: Change the return type of `array_of_inline_tables` to list[dict] from list[str](#3523)

* fix type hint of `parse_name_email` in formats/poetry.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]The type hint of array_of_inline_tables seems to be wrong
2 participants