Fix storing secrets on MacOS #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I merged it. |
|
Thanks! I'd appreciate a release soon so I can get this fix in my distro's package |
|
Thanks! I'd appreciate a release soon so I can get this fix in my distro's package
It's done.
Do you provide a public binary package which I can perhaps refer to
in the Readme?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues:
security add-generic-passwordare not quoted properly; particularly thelabelwhich is of the formoama - foo@example.com(contains spaces) and the OAuth token itself which also contains spaces and double-quotes;add-generic-passwordis called in interactive mode (security -i) in order to prevent the secrets from appearing in the process list, but its input needs an extra newline to be accepted (hPutStr -> hPutStrLn).