Handle urls without the github domain #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
previously approved these changes
May 31, 2017
|
@paulirish Updates? |
|
@m1guelpf can you add a test? |
|
I think if we use Line 29 in 3be1c00 Just need to double check when the method of grabbing the remote was added in git since i know it's semi-new but I think it's probably safe at this point. |
12 tasks
|
Should be all fixed in #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my ssh config if specified that all connections with github should use the github.com domain. So when cloning a repo I can type:
or
instead of
This PR contains a fix for repos that have been cloned without specifying the github domain.