I'm not sure exactly why that code was added as a comment instead of patched in outright, I think @derimagia would be able to answer that?

I do think this is something that should be brought up to the team. 👍

@4U6U57 I added a unit test; let me know if that's sufficient.

Thanks for the patch! Been meaning to switch this over - I wasn't 100% on git versions it was available. We may need to figure this out in a This looks good to me 👍

If you were really concerned about older git versions, you could do something terrible like this...

# check git version
git_version=($(git version | cut -f3 -d' ' | tr '.' ' '))

if [ "${git_version[0]}" -lt 2 -o "${git_version[1]}" -lt 12 ]; then
  giturl=$(git config --get "remote.${remote}.url")
else
  giturl=$(git ls-remote --get-url "$remote")
fi

Instead of checking for the version number, why not check the git help command for the presence of the --get-url parameter?

git help ls-remote | grep '\-\-get-url' | wc -l

Sure, that works.

@paulirish Ideas on how you wanted to deal with versions of git? Another option is just to fall back to the other way in an or statement.

Actually may be a non-issue, looks like it was documented here git/git@2303cad and actually added here git/git@45781ad - that's long enough ago that I don't think we care - thought it was added more recent than that

wow. nice digging!

Yeah I just tried --get-url on an september 2015-era release of git 2.3.7 and it worked great. So yeah 👍 to not worrying about compat on this one.