Enable support for a plethora of more DNS types. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR enables support for all DNS record types available in the miekg/dns package, replacing the previous hardcoded list of 9 specific DNS record types with dynamic support for the full range of DNS types. This addresses the limitation where users needed to query DNS record types like CAA that weren't previously available.
- Replaced hardcoded enum list with dynamic generation from
dns.StringToTypemap - Refactored
ConvertToQTypefunction to use thedns.StringToTypelookup instead of a switch statement - Added alias import to avoid naming conflicts between the external
miekg/dnspackage and internaldnspackage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/server/server.go | Added dynamic DNS record type enumeration and import aliasing to support all DNS types |
| internal/dns/dns.go | Simplified DNS type conversion logic and added CAA record parsing support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current DNS list, although it works, was a bit limiting. Recently I've needed to make a
CAAquery and this tool technically should support it but wasn't available in the list of options.This PR open the floodgates for all dns query types supported by
miekg/dns.