Fix content inspection on specific files treated as binaries. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where certain file extensions (like .go) were incorrectly being treated as binary files during content inspection. The change replaces the MIME type-based detection with a more robust content-based detection approach.
- Replace
mime_guesslibrary withcontent_inspectorfor binary vs text detection - Increase buffer size from 512 to 1024 bytes for better content analysis
- Switch from path-based MIME detection to actual content inspection
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/scanner.rs | Updates the is_text_file method to use content-based detection instead of MIME type guessing |
| Cargo.toml | Adds the content_inspector dependency for improved binary detection |
Comments suppressed due to low confidence (1)
Cargo.toml:23
- The version "0.2" of the content_inspector crate does not exist. The latest available version is "0.2.4". Consider using a more specific version like "0.2.4" or a range like "0.2" if you want to allow patch updates.
content_inspector = "0.2"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some file extensions, such as
.gowould incorrectly be assumed to be binaries.This uses a better library to perform such detection.