Set a default cutoff for Manticore. #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Manticore 5.0, their default cutoff is the same as the search request’s page size - which helps make search requests faster. The unfortunate trade-off is that it means pagination breaks because we no longer know what the actual total number of results is (Manticore stops counting once the cutoff is reached). So, at least for now, we’re going to set a default cutoff of 0, which essentially removes that limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Manticore 5.0, their default cutoff is the same as the search request’s page size - which helps make search requests faster. The unfortunate trade-off is that it means pagination breaks because we no longer know what the actual total number of results is (Manticore stops counting once the cutoff is reached).
So, at least for now, we’re going to set a default cutoff of 0, which essentially removes that limit. Judging by the CI results, Sphinx is fine with this too.