Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Nov 13, 2018

  • Make Wasm build
    • Feature-completeness
    • Move over parachain's GenesisConfig to new API
    • Implement parachain set_heads inherent inspector (if needed)
  • Make native build
    • Basic functionality
    • InherentData API
    • Integrate the new API trait

@gavofyork gavofyork added the A3-in_progress Pull request is in progress. No review needed at this stage. label Nov 13, 2018
@gavofyork gavofyork changed the title Fix up wasm runtime build Fix up Polkadot build Nov 13, 2018
@gavofyork gavofyork changed the title Fix up Polkadot build Make work with Substrate master Nov 13, 2018
@rphmeier
Copy link
Contributor

The set_heads inspector will likely be necessary, since it's meant to exist only once in the block and in a particular position

@gavofyork
Copy link
Member Author

there is already code to check that the block is well-formed. the inspector would be if, for some reason, the client were to need to inspect the inherent (which is a bit of a silly proposition, but the logic was there...)

@rphmeier rphmeier added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Nov 24, 2018
@gavofyork gavofyork merged commit a35ddc5 into master Nov 25, 2018
@gavofyork gavofyork deleted the gav-fix-runtime branch November 25, 2018 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants