Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Jul 13, 2021

closes #3464

@emostov emostov requested a review from kianenigma July 13, 2021 20:38
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jul 13, 2021
@emostov emostov added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jul 13, 2021
Copy link
Contributor

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, CI seems to be having an issue though.

@emostov
Copy link
Contributor Author

emostov commented Jul 14, 2021

bot merge

@ghost
Copy link

ghost commented Jul 14, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Batch: Codebase Restructure' does not match any projects in polkadot's Process.json

@ordian
Copy link

ordian commented Jul 14, 2021

bot merge

@ghost
Copy link

ghost commented Jul 14, 2021

Trying merge.

@ghost ghost merged commit 13c52fe into master Jul 14, 2021
@ghost ghost deleted the zeke-staking-miner-jsonrpsee-v0-3 branch July 14, 2021 17:30
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade staking-miner jsonrpsee to v0.3
3 participants