This repository was archived by the owner on Nov 15, 2023. It is now read-only.
impl ProvideInherent for InclusionInherent #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The data is not injected in the runtime. You already have implemented an inherent for cumulus and there you also injected the data in the node for the runtime. |
It's not clear precisely why this is desired, but it's a pattern I've seen in several places, so I'm going this to be on the safe side. Worst case, we can revert this commit pretty easily.
rphmeier
reviewed
Jun 27, 2020
| @@ -0,0 +1,7 @@ | |||
| //! Inclusion Inherent primitives define types and constants which can be imported | |||
There was a problem hiding this comment.
Thanks! Should be fixed now.
rphmeier
suggested changes
Jun 27, 2020
rphmeier
approved these changes
Jun 29, 2020
rphmeier
reviewed
Jun 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1268.
Modeled on this
ProvideInherentimplementation.It's not obvious where the data is actually injected into
InherentData, but presumably this is the responsibility of the runtime?