This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add some message types from subsystem definitions #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coriolinus
reviewed
Jun 15, 2020
coriolinus
reviewed
Jun 15, 2020
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
rphmeier
commented
Jun 16, 2020
rphmeier
commented
Jun 17, 2020
node/messages/src/lib.rs
Outdated
| /// Chain heads. | ||
| /// | ||
| /// Up to `N` (5?) chain heads. | ||
| pub struct View(Vec<Hash>); |
There was a problem hiding this comment.
Suggested change
| pub struct View(Vec<Hash>); | |
| pub struct View(pub Vec<Hash>); |
There was a problem hiding this comment.
maybe rename to NetworkView also
rphmeier
commented
Jun 17, 2020
node/messages/src/lib.rs
Outdated
| FetchChunk(Hash, u32), | ||
|
|
||
| /// Event from the network bridge. | ||
| NetworkBridgeEvent(NetworkBridgeEvent), |
There was a problem hiding this comment.
The guide calls this NetworkBridgeUpdate
rphmeier
commented
Jun 17, 2020
node/messages/src/lib.rs
Outdated
| DistributeBitfield(Hash, SignedAvailabilityBitfield), | ||
|
|
||
| /// Event from the network bridge. | ||
| NetworkBridgeEvent(NetworkBridgeEvent), |
There was a problem hiding this comment.
The guide calls this NetworkBridgeUpdate
|
Needs to be merged now that #1270 is in, and then is missing a couple message types. Otherwise LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.