Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Apr 21, 2021

useful for some generic code

polkadot companion: paritytech/polkadot#2922

@bkchr
Copy link
Member

bkchr commented Apr 21, 2021

Does not compile

@xlc
Copy link
Contributor Author

xlc commented Apr 21, 2021

also did cargo update -p librocksdb-sys to support M1. let me know if you want this in another PR

@xlc
Copy link
Contributor Author

xlc commented Apr 21, 2021

This is a minor breaking change that people may need to import One or Zero in additional to FixedPointNumber

@bkchr bkchr requested a review from kianenigma April 22, 2021 05:40
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 22, 2021
@bkchr
Copy link
Member

bkchr commented Apr 22, 2021

Still needs a polkadot companion

@bkchr
Copy link
Member

bkchr commented Apr 22, 2021

bot merge

@ghost
Copy link

ghost commented Apr 22, 2021

Trying merge.

@ghost ghost merged commit 4551b3c into paritytech:master Apr 22, 2021
@xlc xlc deleted the zero-and-one branch April 23, 2021 04:19
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants