This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
clean up dependencies for next release #7956
Copy link
Copy link
Closed
Description
for #7947 we want to prune our dependency tree again. mainly this means:
- remove dublicates, where possible
- cargo audit currently identifies 13 dependency that are vulnerable, 3 of which have been yanked.
-
block-cipher
is unmaintained - which we pull in via libp2p, throughchacha20poly1305
(which has an updated version not depending onblock-cipher
), which is a dependency ofsnow
, for which there is no update yet. Required action:- update snow to use latest
chacha20poly1305
, then mcginty/snow@ec32cfa#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542 - need a new release of snow.
- update libp2p-noise to use latest snow. - this might not be necessary if snow can update on a patch-level
- update snow to use latest
-
difference
is unmaintained, we are pulling it in throughsp-state-machine
's dependency .pretty_assertions
. Unfortunately, it appears thatpretty_assertions
is also not maintained anymore (last release and PR merge was Feb 2019, multiple PRs pending since, no updates). Secondly, difference is pullled in fromnode-cli
viaassert_cmd
. Fortunately, it is only a dev-dependency in both cases. No action required. - We are pulling in the unmaintained
failure
-crate viajsonrpc-client-transports
(viajsonrpc-core-client
), new versions have been issues (v17), that do not depend onfailure
anymore. Action:- upgrade to latest jsonrpc-client. Bump jsonrpc-core-client from 15.1.0 to 17.0.0 #7938
-
memmap 0.7.0
, needed by parity-db 0.1.2, is not maintained anymore. But a fork and drop-in-replacement seems to exist:memmap2
. Required actions:- update parity-db to use memmap2, Update Dependencies, switch memmap to memmap2 parity-db#17
- release a new version
- use that version in substrate instead.
-
net2 0.2.35
is not maintained anymore. Recommendation is to usesocket2
instead. It isn't 100% clear but seems that an update ot jsonrpc will also cover this one.- confirm upgrading jsonrpc will fix this.
-
Metadata
Metadata
Assignees
Labels
No labels