Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Revisit location or existence of NetworkStatus #7032

@romanb

Description

@romanb

by @tomaka from #6986 (comment):

NetworkStatus was moved by someone not in the networking team as part of a big PR, and I didn't spot the change.

The entire point of NetworkStatus is to communicate some networking-related information internally between some components without having to depend on sc-network.
Moving it to sc-network entirely defeats this purpose.

It should either be moved back for example to sc-service, or be removed entirely and have everything depend on Arc<NetworkService>.

Metadata

Metadata

Assignees

Labels

I4-annoyanceThe client behaves within expectations, however this “expected behaviour” itself is at issue.I7-refactorCode needs refactoring.Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coder

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions