Fix integration test again #201
Conversation
a47abfb to
c001859
Compare
This reverts commit d3f63ed.
|
CI is red but but... it works on my machine 😭 |
Parent branch: origin/master Forked at: 9e28ea6
|
@bkchr @ddorgan @TriplEight @kianenigma FINALLY FIXED IT!! 🥳 The difference between CI and locally was only because I ran the test from a terminal so the STDIN is kept opened. In the CI, the STDIN is closed. (The validation process got stopped because of that) For someone who made a library that makes pipelines with processes it is infuriating that I didn't see that earlier 😞 |
service/Cargo.toml
Outdated
| # TODO should be dev dependency | ||
| polkadot-test-service = { git = "https://github.com/paritytech/polkadot", branch = "rococo-branch" } |
service/src/lib.rs
Outdated
| let (polkadot_future, polkadot_task_manager) = | ||
| polkadot_collator::start_collator(builder, para_id, collator_key, polkadot_config)?; | ||
| let (polkadot_future, polkadot_task_manager) = if test { | ||
| let (task_manager, client, handles, _network, _rpc_handlers) = polkadot_test_service::polkadot_test_new_full( |
There was a problem hiding this comment.
This should not be done here in this crate.
In the future I also don't want to use the rococo-collator for testing. We need a collator that is just used for testing. We really need to rework all this.
So, please move this functionality for now into the rococo-collator.
|
bot merge |
|
Waiting for commit status. |
No description provided.