-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore: Make reth-errors
crate no_std
compatible
#15790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the reth-errors = { workspace = true, features = ["std"] } activations should be redundant because enforced via zepter's feature delegation, so I'd like to undo all of those and only enforce where necessary,
likely where we need the fs conversion
sorry was not paying attention -- will revert -- I'm not actually sure any crate explicitly uses that From trait, but didn't want to make a breaking change. We could remove the From trait and manually use RethError::other explicitly in the places that need the conversion (if any), then we can get rid of the fs-util dependency and the std feature flag. |
Removed the From trait to see if this compiles in ci (my laptop is not great) |
b6f7004
to
419aabe
Compare
419aabe
to
a6473c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, I think this works, let me fix the ci
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Similar to #15786
The errors crate pulls in fs-util for an error, so to make it std compatible, it required putting that dependency and the FsError type under a
std
feature flag