feat: Add --rollup.sequencer-ws to support WebSocket
#15499
Conversation
There was a problem hiding this comment.
I see,
the question here is do we want the AddOns setup to be async or not.
I'd prefer if we could avoid this and instead try moving the client setup in here:
reth/crates/optimism/node/src/node.rs
Lines 295 to 298 in ef18f95
but need to take a closer look first, but I feel like this should be doable, because we can get access to the
reth/crates/optimism/node/src/node.rs
Line 244 in ef18f95
which also needs an instance
|
Thanks for quick feedback @mattsse, let me try to fix it then! |
| #[tokio::test] | ||
| #[ignore = "Start if WS is reachable at ws://localhost:8546"] | ||
| async fn test_ws_body_str() { | ||
| let client = SequencerClient::new("ws://localhost:8546").await.unwrap(); |
There was a problem hiding this comment.
This requires a node though. Can remove this test, but just in case, it works for me locally
crates/optimism/rpc/src/eth/mod.rs
Outdated
| ctx.components | ||
| .task_executor() | ||
| .handle() | ||
| .block_on(SequencerClient::new(url)) | ||
| .expect("Failed to init sequencer client") |
There was a problem hiding this comment.
Fixed with ur changes. Thanks!
--rollup.sequencer-ws to support WebSocket--rollup.sequencer-ws to support WebSocket
…5499) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Closes #15286
This pr firstly makesNode::add_onsasync (as it is required for making WS connection) and adds flags for sequencer WS (both--rollup.sequencer-wsand--rollup.sequencerwhich supports both).Unfortunately nowSequencerClientcan panic during initialization, as I didn't want to addResultfor add-ons construction.I can remove
--rollup.sequencerand add specific constructors forSequencerClientfor http and ws