-
Notifications
You must be signed in to change notification settings - Fork 221
Closed
Description
We have configured pascalgn/automerge-action
to require 1 review approval before merging a PR. But the action occasionnally refuses to merge a PR that has the required number of approvals, such as this one: 1024pix/pix#4407
Looking into it, we found out that because of pagination in the Github REST API, only the first 30 "reviews" (in the Github API, comments on the PR are returned from the reviews
endpoint as well with state === "COMMENTED"
) were considered and therefore, if those did not include enough APPROVED
reviews the check would fail.
We have a fix that uses a helper method in Octokit, a PR is incoming.
Metadata
Metadata
Assignees
Labels
No labels