Skip to content

Conversation

lpdon
Copy link
Contributor

@lpdon lpdon commented Oct 3, 2021

Possible solution for #76. Moved the join method to an external file with some template juice. Due to backward compatibility with cpp11, some things were done a little uglier than necessary.

@lpdon lpdon force-pushed the output_to_string branch from 78929d6 to 8e34c1f Compare October 3, 2021 10:53
@pantor
Copy link
Owner

pantor commented Oct 4, 2021

Hey @lpdon, thanks for your PR (and quick response to #76)! I've added some comments inline.

@lpdon
Copy link
Contributor Author

lpdon commented Oct 4, 2021

Hey @lpdon, thanks for your PR (and quick response to #76)! I've added some comments inline.

hey, no problem. However, I can't see your comments 😅

@pantor
Copy link
Owner

pantor commented Oct 4, 2021

Ups, here we go...

@lpdon lpdon force-pushed the output_to_string branch from 8e34c1f to 5724386 Compare October 4, 2021 15:19
@pantor pantor merged commit b836e94 into pantor:master Oct 10, 2021
@pantor
Copy link
Owner

pantor commented Oct 10, 2021

Thank you! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants