-
Notifications
You must be signed in to change notification settings - Fork 227
Closed
Description
Hi!
I'm getting warnings about unused parameter 'node'
in this function:
inja/include/inja/renderer.hpp
Line 121 in 3cc82e9
Arguments get_argument_vector(size_t N, const AstNode& node) { |
Function get_arguments
uses node
parameter to throw exception. So I don't know if it is right to remove node
parameter from get_argument_vector
function, or it is better to add a similar check as in get_arguments
function:
inja/include/inja/renderer.hpp
Lines 98 to 101 in 3cc82e9
std::array<const json*, N> get_arguments(const AstNode& node) { | |
if (json_eval_stack.size() < N) { | |
throw_renderer_error("function needs " + std::to_string(N) + " variables, but has only found " + std::to_string(json_eval_stack.size()), node); | |
} |
Compiling using g++ 10.2.0
with -Wall -Wextra
flags.
Metadata
Metadata
Assignees
Labels
No labels