Skip to content

Don't set the cli attribute in the sansio scaffold #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2024
Merged

Don't set the cli attribute in the sansio scaffold #5270

merged 1 commit into from
Apr 7, 2024

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Oct 1, 2023 •
edited
Loading

It is (currently) Flask specific and hence cannot be shared in the sansio shared code.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@pgjones pgjones force-pushed the cli branch 2 times, most recently from d5a5d34 to cfdb245 Compare December 14, 2023 20:06
1shaperformance

This comment was marked as off-topic.

Sign in to view

@pgjones @davidism
Don't set the cli attribute in the sansio scaffold
5fdce4c 
It is (currently) Flask specific and hence cannot be shared in the
sansio shared code.
@davidism davidism added this to the 3.0.3 milestone Apr 7, 2024
@davidism davidism merged commit 5e22cc9 into pallets:3.0.x Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
@pgjones pgjones deleted the cli branch April 27, 2024 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@1shaperformance 1shaperformance 1shaperformance left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@pgjones @1shaperformance @davidism