Fix flag value set when is_flag=True and type is provided #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5bb990 to
3120a70
Compare
dbaxa
reviewed
May 20, 2025
Co-authored-by: Nate Herbert <nateherbert@gmail.com>
e6e99a0 to
4fd2fea
Compare
This was referenced May 20, 2025
This was referenced May 20, 2025
Merged
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the value of a flag, check only if
is_flagisTrueandflag_valueis not provided when negating the default flag value.#2829 introduced a bug by checking if the type of the flag is
Nonebefore setting the value.Since we still check if
is_flagis set, objects without a__bool__method will not raise an error ifis_flagis not set.fixes #2894
fixes #2897