Give a UserWarning when Parameter is overriden by name #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue recently caused Chia a little grief when a short name collision was merged in - so I'm in support of this concept. |
8778b31 to
92be37c
Compare
cca0c46 to
b9f0ae3
Compare
|
The implementation proposed here checks every single time an option is used, whether its name has been used before. I moved this check to Additionally, the error message does not tell you which parameters. That could technically be done, but I'm not sure it's worth the extra time spent as it should be relatively straightforward to figure out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a UserWarning when two parameters on one command have a name conflict. Very interested in thoughts and feedback.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.