Skip to content

raise ValueError for duplicate flags #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2020
Merged

raise ValueError for duplicate flags #1594

merged 1 commit into from
Jun 25, 2020
+12 −0

Conversation

0x1za
Copy link
Contributor

@0x1za 0x1za commented Jun 18, 2020 •
edited by davidism
Loading

Specifying the same flag name twice will raise a RuntimeError.

@click.option( "--foo/--foo", default=False)

fixes #1465

@davidism davidism mentioned this pull request Jun 18, 2020
Closed
@0x1za

This comment has been minimized.

Sign in to view
@davidism davidism added this to the 8.0.0 milestone Jun 25, 2020
@davidism davidism force-pushed the duplicate-boolean-flags branch from 09ea9df to 7de4708 Compare June 25, 2020 04:53
@davidism davidism changed the title raise warning for duplicate flags raise ValueError for duplicate flags Jun 25, 2020
@davidism
Copy link
Member

Squashed, rebased, added changelog, reverted changes to requirements/tests.txt, raised ValueError instead of TypeError.

@davidism davidism merged commit dfb842d into pallets:master Jun 25, 2020
@davidism davidism deleted the duplicate-boolean-flags branch June 25, 2020 04:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Duplicate Boolean flag options "--foo/--foo" are not detected (defaults to False)
2 participants
@0x1za @davidism