Skip to content

Click tests fails on Python 3.12.0-beta.1 #2524

@kdeldycke

Description

@kdeldycke

The last test job on main branch dates back to a month ago. At that time Python 3.12.0-alpha.7 was used and everything went fine: https://github.com/pallets/click/actions/runs/4874262829/jobs/8694965847#step:3:33

With the release of Python 3.12.0-beta.1, Click tests are failing on the 3.12-dev job, with the following issue:

==================================== ERRORS ====================================
___________________ ERROR collecting tests/test_arguments.py ___________________
/opt/hostedtoolcache/Python/3.12.0-beta.1/x64/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1293: in _gcd_import
    ???
<frozen importlib._bootstrap>:1266: in _find_and_load
    ???
<frozen importlib._bootstrap>:1237: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:841: in _load_unlocked
    ???
.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:163: in exec_module
    source_stat, co = _rewrite_test(fn, self.config)
.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:346: in _rewrite_test
    rewrite_asserts(tree, source, strfn, config)
.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:407: in rewrite_asserts
    AssertionRewriter(module_path, config, source).run(mod)
.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:965: in visit_Name
    inlocs = ast.Compare(ast.Str(name.id), [ast.In()], [locs])
/opt/hostedtoolcache/Python/3.12.0-beta.1/x64/lib/python3.12/ast.py:584: in _new
    warnings._deprecated(
/opt/hostedtoolcache/Python/3.12.0-beta.1/x64/lib/python3.12/warnings.py:529: in _deprecated
    warn(msg, DeprecationWarning, stacklevel=3)
E   DeprecationWarning: ast.Str is deprecated and will be removed in Python 3.14; use ast.Constant instead
...

See for instance my latest #2523 PR: https://github.com/pallets/click/actions/runs/5121540227/jobs/9209435195?pr=2523#step:7:73

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions