Match JndiManager classes with a renamed file extension #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
glynternet
requested changes
Jan 19, 2022
6455b10 to
0291504
Compare
glynternet
approved these changes
Jan 19, 2022
pkg/crawl/identify.go
Outdated
| return fileNameMatchesLog4jVersion(filename) | ||
| } | ||
|
|
||
| func filenameFromPath(path string) string { |
There was a problem hiding this comment.
nit: Can we rename this to filenameFromPathInsideArchive so that semantically it's clear that we are only concerned with archive-specific path separators?
b3d333a to
30baff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: jars or other archives that contained a JndiManager class with a different extension, such as JndiManger.classdata, would be missed
After: any file called JndiManager, regardless of extension, will be checked for hash matches against known versions