Skip to content

[ControlGroup] Border radius not inherited by components with popovers #2730

@badams

Description

@badams

Environment

  • Package version(s): 3.0.1
  • Browser and OS versions: Chrome 67.0.3396.99 (Official Build) (64-bit)

Steps to reproduce

Add a popover to a button that is inside a control group

 <ControlGroup>
    <Popover content={<p>Hello</p>}>
        <Button text="Open"/>
    </Popover>
    <Button icon="cross"/>
</ControlGroup>

Actual behavior

Border radius is not inherited by components wrapped in a popover, eg <Select />, <Button />

screen shot 2018-07-27 at 10 55 05 am

Expected behavior

Components should inherit border radius based on their position in the ControlGroup

screen shot 2018-07-27 at 10 54 47 am

Possible solution

Add border-radius: inherit to popover-target and popover-wrapper when inside a control group

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions