[MLDM-111] snapshot cmd: list, create, and delete #10390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
b6c5837 to
0cac07a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10390 +/- ##
==========================================
- Coverage 62.28% 62.23% -0.05%
==========================================
Files 1227 1229 +2
Lines 88121 88206 +85
Branches 1820 1820
==========================================
+ Hits 54884 54895 +11
- Misses 32396 32470 +74
Partials 841 841 ☔ View full report in Codecov by Sentry. |
0cac07a to
d6a99d6
Compare
bbeb751 to
a661690
Compare
b78cc9a to
b178a69
Compare
FahadBSyed
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
pachctl create snapshot,pachctl list snapshot,pachctl delete snapshotcommands.delete snapshot hasn't been tested because delete snapshot gRPC hasn't been merged.
possible next PR:
add delete snapshot in test; add inspect snapshot