Skip to content

Conversation

Zhang-Muyang
Copy link
Contributor

@Zhang-Muyang Zhang-Muyang commented Oct 5, 2024

This PR does the following:
Basic gRPC infrastructure. Snapshot, Snapshotdb, proto files.
CreateSnapshot, ListSnapshot RPC and DB CRUD

Todo:
Add comments as needed
Merge with recovery folder as needed

Next PR:
InspectSnapshot and DeleteSnapshot RPC

@Zhang-Muyang Zhang-Muyang marked this pull request as draft October 5, 2024 04:49
Copy link

github-actions bot commented Oct 5, 2024

size-limit report 📦

Path Size
Entry 93.08 KB (-0.05% 🔽)
Vendor XL 800.86 KB (0%)
Chunks 292.49 KB (+0.01% 🔺)
Everything 1.16 MB (-0.01% 🔽)

@Zhang-Muyang Zhang-Muyang changed the title Don't review CreateSnapshot, ListSnapshot RPC and DB CRUD Oct 8, 2024
@Zhang-Muyang Zhang-Muyang marked this pull request as ready for review October 8, 2024 16:47
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 62.19%. Comparing base (3f5368d) to head (6c9458a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/internal/snapshot/api_server.go 56.75% 16 Missing ⚠️
src/internal/pachd/env.go 71.42% 2 Missing and 2 partials ⚠️
src/internal/snapshotdb/snapshot_crud.go 84.61% 4 Missing ⚠️
src/internal/pachd/builder.go 71.42% 1 Missing and 1 partial ⚠️
src/internal/pachd/full.go 92.85% 1 Missing ⚠️
src/internal/snapshotdb/snapshotdb.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10371      +/-   ##
==========================================
+ Coverage   61.82%   62.19%   +0.37%     
==========================================
  Files        1258     1225      -33     
  Lines       88662    87966     -696     
  Branches     2055     1820     -235     
==========================================
- Hits        54817    54713     -104     
+ Misses      32980    32417     -563     
+ Partials      865      836      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zhang-Muyang Zhang-Muyang requested a review from jrockway October 8, 2024 17:16
Copy link
Contributor

@jrockway jrockway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RPC server needs to be hooked into the real pachd here: https://github.com/pachyderm/pachyderm/blob/master/src/internal/pachd/full.go#L122 and testpachd here: https://github.com/pachyderm/pachyderm/blob/master/src/internal/pachd/full.go#L500 and pachctl misc grpc here: https://github.com/pachyderm/pachyderm/blob/master/src/server/misc/cmds/grpc.go#L50

After that, you should be able to test these methods with pachctl misc grpc snapshot.API.CreateSnapshot {} and similar.

Copy link
Contributor

@jrockway jrockway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Zhang-Muyang Zhang-Muyang merged commit 78ed4c9 into master Oct 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants