-
Notifications
You must be signed in to change notification settings - Fork 566
CreateSnapshot, ListSnapshot RPC and DB CRUD #10371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10371 +/- ##
==========================================
+ Coverage 61.82% 62.19% +0.37%
==========================================
Files 1258 1225 -33
Lines 88662 87966 -696
Branches 2055 1820 -235
==========================================
- Hits 54817 54713 -104
+ Misses 32980 32417 -563
+ Partials 865 836 -29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RPC server needs to be hooked into the real pachd here: https://github.com/pachyderm/pachyderm/blob/master/src/internal/pachd/full.go#L122 and testpachd here: https://github.com/pachyderm/pachyderm/blob/master/src/internal/pachd/full.go#L500 and pachctl misc grpc
here: https://github.com/pachyderm/pachyderm/blob/master/src/server/misc/cmds/grpc.go#L50
After that, you should be able to test these methods with pachctl misc grpc snapshot.API.CreateSnapshot {}
and similar.
7c5ba61
to
23676de
Compare
23676de
to
ab1c5b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This PR does the following:
Basic gRPC infrastructure. Snapshot, Snapshotdb, proto files.
CreateSnapshot, ListSnapshot RPC and DB CRUD
Todo:
Add comments as needed
Merge with
recovery
folder as neededNext PR:
InspectSnapshot and DeleteSnapshot RPC