Take database dumps during snapshots #10367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10367 +/- ##
========================================
Coverage 62.17% 62.17%
========================================
Files 1221 1222 +1
Lines 87719 87846 +127
Branches 1820 1820
========================================
+ Hits 54537 54619 +82
- Misses 32348 32391 +43
- Partials 834 836 +2 ☔ View full report in Codecov by Sentry. |
Zhang-Muyang
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
pg_dumpto dump the database after creating the snapshot row. I have imported pg_dump binaries from the latest Debian builds of postgres. pg_dump must be newer than the running Postgres, so I have used version 17 of pg_dump (for our supported version of 13).I have filed some separate issues to add pg_dump to the containers (easy for the pachdev one, hard for the pachd one; we might switch the release to using the pachdev containers), and to add some zombie process reaping functionality to pachd, since this is the first place where pachd will spawn a subprocess.
Tomorrow I will do some testing on MacOS and arm64 Linux. I think we can make MacOS work for running the tests, but pg_dump has to be obtained differently. Not a big deal. arm64 should work but I haven't tried it yet.