Always Write Job Cache Metadata for Jobs (So We Know When to Respect cache-write and cache-read) #10353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4988ff6 to
0fd1990
Compare
size-limit report 📦
|
FahadBSyed
commented
Sep 25, 2024
| @@ -42,14 +42,13 @@ func createPJSSchema(ctx context.Context, env migrations.Env) error { | |||
| ); | |||
| -- PJS has a server side cache for jobs. Utilizing this cache allows PJS to skip subtrees when spawning job trees. | |||
| CREATE TABLE pjs.job_cache ( | |||
| job_hash BYTEA NOT NULL, | |||
| job_id BIGINT REFERENCES pjs.jobs(id) ON DELETE CASCADE, | |||
| job_id BIGINT REFERENCES pjs.jobs(id) ON DELETE CASCADE PRIMARY KEY, | |||
There was a problem hiding this comment.
A stub necessitates that we may write an entry to this table without the job hash being there.
0fd1990 to
229778b
Compare
src/internal/pjsdb/job_cache.go
Outdated
| `, job.ID, job.ReadEnabled, job.WriteEnabled) | ||
| } | ||
|
|
||
| // a full write is only done on a cache hit. |
There was a problem hiding this comment.
I just reviewed a PR of Bob's static check of comments. The comments would be better starts with "writeToJobCache" does something (to pass the checks) 😀 . Same applies to other functions.
…hen cache-write=false.
229778b to
c8e1bc3
Compare
Zhang-Muyang
approved these changes
Sep 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10353 +/- ##
==========================================
- Coverage 62.15% 62.14% -0.01%
==========================================
Files 1218 1218
Lines 87602 87619 +17
Branches 1820 1820
==========================================
+ Hits 54448 54453 +5
- Misses 32314 32333 +19
+ Partials 840 833 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.