Skip to content

[MLDM-29] Queue CRUD #10268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2024
Merged

[MLDM-29] Queue CRUD #10268

merged 2 commits into from
Aug 19, 2024

Conversation

Zhang-Muyang
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

size-limit report 📦

Path Size
Entry 92.96 KB (0%)
Vendor XL 801.19 KB (0%)
Chunks 292.45 KB (0%)
Everything 1.16 MB (0%)

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.65%. Comparing base (0545ac5) to head (f36a28e).
Report is 2 commits behind head on master.

Files Patch % Lines
src/internal/pjsdb/errors.go 0.00% 4 Missing ⚠️
src/internal/pjsdb/queue_crud.go 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10268      +/-   ##
==========================================
+ Coverage   58.29%   58.65%   +0.35%     
==========================================
  Files         642      642              
  Lines       77193    77228      +35     
==========================================
+ Hits        45000    45295     +295     
+ Misses      31692    31443     -249     
+ Partials      501      490      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FahadBSyed
FahadBSyed reviewed Aug 14, 2024
View reviewed changes
src/internal/pjsdb/queue_iterator.go
pjs.jobs j
ON j.program_hash = queues.program_hash
WHERE
j.processing IS NULL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I don't think the queues iterator should automatically filter out jobs that are not done. Instead, that should be done in the filter.

Rationale here is that you may want to see all jobs in a queue, even the done ones. There wouldn't be a way to do that through the API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we discussed this in slack and decided we want a queue to be all jobs with the same program in a 'queued' stated only.

@FahadBSyed FahadBSyed self-requested a review August 15, 2024 15:55
@Zhang-Muyang Zhang-Muyang merged commit abbc4f1 into master Aug 19, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FahadBSyed FahadBSyed FahadBSyed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhang-Muyang @FahadBSyed